Handle replication lag when authenticating with a Bearer Token #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisRayM
changed the title
DavisRayM
force-pushed
the
1920-bearer-token-replication-lag
branch
from
2e624ec
to
4956a2a
Compare
DavisRayM
changed the title
DavisRayM
force-pushed
the
1920-bearer-token-replication-lag
branch
3 times, most recently
from
804bfbb
to
bfa855f
Compare
Test that the MasterReplicaOAuth2Validator fetches from the Master Database if it fails to retrieve the AccessToken from the Read Replica
DavisRayM
force-pushed
the
1920-bearer-token-replication-lag
branch
from
bfa855f
to
8a22e4c
Compare
DavisRayM
changed the title
DavisRayM
force-pushed
the
1920-bearer-token-replication-lag
branch
from
8a22e4c
to
593ef72
Compare
|
Complexity increasing per file
==============================
- onadata/apps/api/viewsets/connect_viewset.py 1
See the complete overview on Codacy |
ukanga
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
MasterReplicaOAuth2ValidatorclassMasterReplicaOAuth2Validatoras the OAuth2 Request validatorUserProfilefrom main database on failureSteps taken to verify this change does what is intended
Side effects of implementing this change
AccessTokenfrom the read replica, the application will now try to retrieve theAccessTokenfrom the master database.Closes #1920